-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug golangci-lint #5988
Closed
Closed
Debug golangci-lint #5988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5988 +/- ##
=======================================
Coverage 17.92% 17.92%
=======================================
Files 110 110
Lines 10421 10421
=======================================
Hits 1868 1868
Misses 8096 8096
Partials 457 457
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
I went ahead and bumped the version of golangci-lint up by one minor version. |
Signed-off-by: Nishant Mittal <mittalnishant14@outlook.com>
…angci-lint Signed-off-by: Nishant Mittal <mittalnishant14@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/ci
Continuous Integration
component/mesheryctl
CLI for Meshery
pr/do-not-merge
PRs not ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Debug the failures of golangci-lint. This pr is for debug purpose only as i am not able to reproduce the failure locally.
This PR fixes #
Notes for Reviewers
Signed commits